removed opacity and updated shading by vivekmaurya001 · Pull Request #1862 · layer5io/sistent

vivekmaurya001 · 2026-10-07T08:04:01Z

Notes for Reviewers

This PR fixes #1805
removed extra fading and maded disabled button text darker

Before
Screencast from 2026-10-09 11-54-11.webm
After
Screencast from 2026-10-09 11-53-31.webm

Signed commits

Yes, I signed my commits.

Summary by CodeRabbit

Style
- Permission-restricted content retains its existing opacity while remaining non-interactive.
- Disabled contained and outlined buttons now use secondary text coloring; their backgrounds and outlined borders are unchanged.

coderabbitai · 2026-10-07T08:04:24Z

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 4d0f9c84-1857-40c1-9037-8ab2929c26b5

📥 Commits

Reviewing files that changed from the base of the PR and between 392d8f2 and 1436e73.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 2543a16a-bf76-443d-ad99-0fe1f4050c3f

📥 Commits

Reviewing files that changed from the base of the PR and between 36d21d6 and f143c52.

📒 Files selected for processing (1)

src/base/Button/Button.tsx

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

📝 Walkthrough

Walkthrough

When a button lacks its required permission, it remains disabled. In light mode, it applies a disabled text color from theme.palette.text.default and retains existing props.sx styles.

Changes

Permission-denied button styling

Layer / File(s)	Summary
Disabled text color `src/base/Button/Button.tsx`	The permission-denied button sets `disabled` and applies a light-mode text color override before existing `props.sx` styles. The theme callback adds no styles in dark mode.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: maanvi212006

Merge Risk: ⚪ Minimal · up to 392d8

Permission-denied buttons remain disabled and have readable light-mode text contrast. No merge-blocking issue is established.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 3 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check		Issue `#1805` requires readable text contrast for the light-mode Native Button Gating demo. The PR updates the permission-denied `Button` path. In light mode, the disabled MUI button uses `theme.palette…
Out of Scope Changes check		The whole-PR diff changes only `src/base/Button/Button.tsx`. The change applies the light-mode disabled text color to the permission-gated button and preserves existing `sx` styles. This change suppor…
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title relates to the changes by describing the removal of opacity and the update to disabled-button shading. It is somewhat broad but remains relevant to the main change.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Maanvi212006

Can you attach a short screen recording or before/after screenshots of the whole permissions page in light and dark mode, including Export Design / Manage Roles buttons ? Removing the shield's opacity affects them too, and the goal is that the native button looks identical to those.

Maanvi212006

Also, please add sign-off to the commit. You can follow the steps on this page to do so.

Signed-off-by: vivekmaurya001 <vm8118134@gmail.com>

vivekmaurya001 · 2026-10-09T06:42:29Z

@Maanvi212006 please check, I have removed affects on others and included the video

Maanvi212006

looks good! the text is readable in light now in light mode.

resolve the DCO failure
open an issue to apply the same fix to "Create Workspace" and "Manage Organizations (Needs AnyOf)" button on this page.

leecalcote

Thanks @vivekmaurya001 for picking up #1805, the before/after recordings make the improvement easy to see, and merging the caller's sx (array or object) rather than overwriting it is careful work.

Things to address:

The DCO check is failing. Could you sign off your commits (git commit --amend -s or git rebase --signoff) and force-push?
The override only applies in light mode. If dark mode has the same readability issue, it would be nice to handle both, otherwise a short comment explaining why dark mode is excluded helps future readers (inline note).
The title could be more descriptive, for example [Button] Improve readability of permission-disabled buttons.
There is an outstanding changes-requested review; please make sure those points are addressed too.

leecalcote · 2026-10-13T16:05:13Z

+        disabled
+        sx={[
+          (theme) =>
+            theme.palette.mode === 'light'


Is dark mode intentionally left unchanged? If disabled text is also hard to read there, using a single token that works in both modes (rather than branching on palette.mode) would keep the two themes in parity. If light-only is intentional, a one-line comment here would help.

removed opacity and updated shading

36d21d6

Maanvi212006 reviewed Oct 8, 2026

View reviewed changes

Maanvi212006 requested changes Oct 8, 2026

View reviewed changes

vivekmaurya001 added 2 commits October 9, 2026 12:00

updated other effects

f143c52

signed commit Signed-off-by: vivek maurya <vm8118134@gmail.com>

392d8f2

Signed-off-by: vivekmaurya001 <vm8118134@gmail.com>

Maanvi212006 reviewed Oct 10, 2026

View reviewed changes

Merge branch 'master' into visibility-text

1436e73

leecalcote reviewed Oct 13, 2026

View reviewed changes

Navigation Menu

Repository navigation

removed opacity and updated shading - #1862

removed opacity and updated shading#1862
vivekmaurya001 wants to merge 4 commits into
layer5io:masterfrom
vivekmaurya001:visibility-text

vivekmaurya001 commented Oct 7, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 7, 2026 •

edited

Loading

Review skipped

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

Maanvi212006 left a comment

Uh oh!

Maanvi212006 left a comment

Uh oh!

vivekmaurya001 commented Oct 9, 2026

Uh oh!

Maanvi212006 left a comment •

edited

Loading

Uh oh!

leecalcote left a comment

Uh oh!

leecalcote Oct 13, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

vivekmaurya001 commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

Maanvi212006 left a comment

Choose a reason for hiding this comment

Uh oh!

Maanvi212006 left a comment

Choose a reason for hiding this comment

Uh oh!

vivekmaurya001 commented Oct 9, 2026

Uh oh!

Maanvi212006 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

leecalcote left a comment

Choose a reason for hiding this comment

Uh oh!

leecalcote Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vivekmaurya001 commented Oct 7, 2026 •

edited

Loading

coderabbitai Bot commented Oct 7, 2026 •

edited

Loading

Maanvi212006 left a comment •

edited

Loading